mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix an use-after-free

Browse Source 
Because we “delete all node” and then we use the content of one of these
nodes we got earlier.
This commit is contained in:
louiz’
2017-01-06 23:09:17 +01:00
parent 5b56007828
commit 17411e6b44
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
louloulibs/xmpp/adhoc_command.cpp
+2 -1
View File
@@ -54,10 +54,11 @@ void HelloStep2(XmppComponent&, AdhocSession& session, XmlNode& command_node)
{ {
if (const XmlNode* value = name_field->get_child("value", "jabber:x:data")) if (const XmlNode* value = name_field->get_child("value", "jabber:x:data"))
{ {
const std::string value_str = value->get_inner();
command_node.delete_all_children(); command_node.delete_all_children();
XmlSubNode note(command_node, "note"); XmlSubNode note(command_node, "note");
note["type"] = "info"; note["type"] = "info";
note.set_inner("Hello "s + value->get_inner() + "!"s); note.set_inner("Hello "s + value_str + "!"s);
return; return;
} }
} }