Remove two sneaky log_debug

src/irc/irc_client.cpp

@@ -888,7 +888,7 @@ void IrcClient::on_part(const IrcMessage& message)
         // channel pointer is now invalid
         channel = nullptr;
       }
-      this->bridge.send_muc_leave(std::move(iid), std::move(nick), std::move(txt), self);
+      this->bridge.send_muc_leave(iid, std::move(nick), std::move(txt), self);
     }
 }
 
@@ -906,7 +906,7 @@ void IrcClient::on_error(const IrcMessage& message)
     if (!channel->joined)
       continue;
     std::string own_nick = channel->get_self()->nick;
-    this->bridge.send_muc_leave(std::move(iid), std::move(own_nick), leave_message, true);
+    this->bridge.send_muc_leave(iid, std::move(own_nick), leave_message, true);
   }
   this->channels.clear();
   this->send_gateway_message("ERROR: "s + leave_message);
@@ -930,7 +930,7 @@ void IrcClient::on_quit(const IrcMessage& message)
           iid.set_local(chan_name);
           iid.set_server(this->hostname);
           iid.type = Iid::Type::Channel;
-          this->bridge.send_muc_leave(std::move(iid), std::move(nick), txt, false);
+          this->bridge.send_muc_leave(iid, std::move(nick), txt, false);
         }
     }
 }

src/irc/irc_client.hpp

@@ -52,7 +52,7 @@ public:
   /**
    * Close the connection, remove us from the poller
    */
-  void on_connection_close(const std::string& error) override final;
+  void on_connection_close(const std::string& error_msg) override final;
   /**
    * Parse the data we have received so far and try to get one or more
    * complete messages from it.

src/irc/irc_message.cpp

@@ -8,12 +8,12 @@ IrcMessage::IrcMessage(std::string&& line)
   // optional prefix
   if (line[0] == ':')
     {
-      pos = line.find(" ");
+      pos = line.find(' ');
       this->prefix = line.substr(1, pos - 1);
       line = line.substr(pos + 1, std::string::npos);
     }
   // command
-  pos = line.find(" ");
+  pos = line.find(' ');
   this->command = line.substr(0, pos);
   line = line.substr(pos + 1, std::string::npos);
   // arguments
@@ -24,7 +24,7 @@ IrcMessage::IrcMessage(std::string&& line)
           this->arguments.emplace_back(line.substr(1, std::string::npos));
           break ;
         }
-      pos = line.find(" ");
+      pos = line.find(' ');
       this->arguments.emplace_back(line.substr(0, pos));
       line = line.substr(pos + 1, std::string::npos);
     } while (pos != std::string::npos);

src/irc/irc_user.cpp

@@ -21,7 +21,7 @@ IrcUser::IrcUser(const std::string& name,
       name_begin++;
     }
 
-  const std::string::size_type sep = name.find("!", name_begin);
+  const std::string::size_type sep = name.find('!', name_begin);
   if (sep == std::string::npos)
     this->nick = name.substr(name_begin);
   else

src/irc/irc_user.hpp

@@ -23,7 +23,7 @@ public:
 
   void add_mode(const char mode);
   void remove_mode(const char mode);
-  char get_most_significant_mode(const std::vector<char>& sorted_user_modes) const;
+  char get_most_significant_mode(const std::vector<char>& modes) const;
 
   std::string nick;
   std::string host;