mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a sqlite3 leak when the database fails to open

Browse Source
This commit is contained in:
louiz’
2017-08-19 13:02:34 +02:00
parent 9648fd286c
commit 2a62b8b082
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/database/database.cpp
+2 -1
View File
@@ -23,12 +23,13 @@ void Database::open(const std::string& filename)
// not, just leave things untouched // not, just leave things untouched
sqlite3* new_db; sqlite3* new_db;
auto res = sqlite3_open_v2(filename.data(), &new_db, SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE, nullptr); auto res = sqlite3_open_v2(filename.data(), &new_db, SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE, nullptr);
Database::close();
if (res != SQLITE_OK) if (res != SQLITE_OK)
{ {
log_error("Failed to open database file ", filename, ": ", sqlite3_errmsg(new_db)); log_error("Failed to open database file ", filename, ": ", sqlite3_errmsg(new_db));
sqlite3_close_v2(new_db);
throw std::runtime_error(""); throw std::runtime_error("");
} }
Database::close();
Database::db = new_db; Database::db = new_db;
Database::muc_log_lines.create(Database::db); Database::muc_log_lines.create(Database::db);
Database::muc_log_lines.upgrade(Database::db); Database::muc_log_lines.upgrade(Database::db);