add default_persistence_allowed

In addition set all config options in every test, as catch2 can run
tests out of order and as demonstrated in
e1ad60af4f this can be an issue
This commit is contained in:
Luca Matei Pintilie
2025-11-28 21:54:38 +01:00
committed by mathieui
parent fbb93dbd08
commit 51930c1e78
4 changed files with 47 additions and 4 deletions
+36
View File
@@ -9,6 +9,31 @@ TEST_CASE("default")
Config::clear();
Config::set("persist_user_denylist", "");
Config::set("persist_user_allowlist", "");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == true);
Config::clear();
}
TEST_CASE("default - default_persistence_allowed - false")
{
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_denylist", "");
Config::set("persist_user_allowlist", "");
Config::set("default_persistence_allowed", "false");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == false);
Config::clear();
}
TEST_CASE("default - default_persistence_allowed - true")
{
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_denylist", "");
Config::set("persist_user_allowlist", "");
Config::set("default_persistence_allowed", "true");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == true);
Config::clear();
@@ -19,6 +44,8 @@ TEST_CASE("denylist - jid")
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_denylist", "foo@example.com");
Config::set("persist_user_allowlist", "");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == false);
Config::clear();
@@ -29,6 +56,8 @@ TEST_CASE("denylist - domain")
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_denylist", "example.com");
Config::set("persist_user_allowlist", "");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == false);
Config::clear();
@@ -39,6 +68,8 @@ TEST_CASE("allowlist - jid")
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_allowlist", "foo@example.com");
Config::set("persist_user_denylist", "");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == true);
Config::clear();
@@ -49,6 +80,8 @@ TEST_CASE("allowlist - domain")
Jid jid("foo@example.com");
Config::clear();
Config::set("persist_user_allowlist", "example.com");
Config::set("persist_user_denylist", "");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == true);
Config::clear();
@@ -60,6 +93,7 @@ TEST_CASE("denylist + allowlist - deny domain, allow jid")
Config::clear();
Config::set("persist_user_denylist", "example.com");
Config::set("persist_user_allowlist", "foo@example.com");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == true);
Config::clear();
@@ -71,6 +105,7 @@ TEST_CASE("denylist + allowlist - deny jid, allow domain")
Config::clear();
Config::set("persist_user_denylist", "foo@example.com");
Config::set("persist_user_allowlist", "example.com");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == false);
Config::clear();
@@ -82,6 +117,7 @@ TEST_CASE("denylist + allowlist - deny jid, allow jid")
Config::clear();
Config::set("persist_user_denylist", "foo@example.com");
Config::set("persist_user_allowlist", "foo@example.com");
Config::set("default_persistence_allowed", "");
bool result = utils::is_requester_allowed_to_persist(jid);
CHECK(result == false);
Config::clear();