mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Parse the timezone myself, instead of using the broken strptime

Browse Source 
See

https://lab.louiz.org/louiz/biboumi/issues/3215
https://github.com/andikleen/glibc/blob/master/time/strptime_l.c#L746-L747

for why strptime() sucks

We use std::get_time now, to parse the date and time. And we parse the
timezone by hand.

fix #3215
This commit is contained in:
louiz’
2016-10-11 00:20:43 +02:00
parent 116472920c
commit 548e4ad473
2 changed files with 53 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/utils.cpp
+14 -2
View File
@@ -124,7 +124,19 @@ TEST_CASE("time_to_string")
TEST_CASE("parse_datetime")
{
CHECK(utils::parse_datetime("1970-01-01T00:00:00z") == 0);
CHECK(utils::parse_datetime("1970-01-01T00:00:00Z") == 0);
const int twenty_three_hours = 82800;
CHECK(utils::parse_datetime("1970-01-01T23:00:12Z") == twenty_three_hours + 12);
CHECK(utils::parse_datetime("1970-01-01T23:00:12Z") == utils::parse_datetime("1970-01-01T23:00:12+00:00"));
CHECK(utils::parse_datetime("1970-01-01T23:00:12Z") == utils::parse_datetime("1970-01-01T23:00:12-00:00"));
CHECK(utils::parse_datetime("1970-01-02T00:00:12Z") == utils::parse_datetime("1970-01-01T23:00:12-01:00"));
CHECK(utils::parse_datetime("1970-01-02T00:00:12Z") == utils::parse_datetime("1970-01-02T01:00:12+01:00"));
CHECK(utils::parse_datetime("2016-08-29T14:29:29Z") == 1472480969);
CHECK(utils::parse_datetime("blah") == -1);
}
CHECK(utils::parse_datetime("1970-01-02T00:00:12B") == -1);
CHECK(utils::parse_datetime("1970-01-02T00:00:12*00:00") == -1);
CHECK(utils::parse_datetime("1970-01-02T00:00:12+0000") == -1);
}