mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a use after free in IrcChannel::remove_user

Browse Source
This commit is contained in:
louiz’
2016-06-23 22:16:13 +02:00
parent c1f678e450
commit 57263961b4
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/irc/irc_channel.cpp
+8 -5
View File
@@ -37,11 +37,14 @@ IrcUser* IrcChannel::find_user(const std::string& name) const
void IrcChannel::remove_user(const IrcUser* user) void IrcChannel::remove_user(const IrcUser* user)
{ {
this->users.erase(std::remove_if(this->users.begin(), this->users.end(), const auto nick = user->nick;
[user](const std::unique_ptr<IrcUser>& u) const auto it = std::find_if(this->users.begin(), this->users.end(),
{ [nick](const std::unique_ptr<IrcUser>& u)
return user->nick == u->nick; {
}), this->users.end()); return nick == u->nick;
});
if (it != this->users.end())
this->users.erase(it);
} }
void IrcChannel::remove_all_users() void IrcChannel::remove_all_users()