Clean a few more things

louloulibs/network/dns_handler.cpp

@@ -8,7 +8,6 @@
 #include <utils/timed_events.hpp>
 
 #include <algorithm>
-#include <stdexcept>
 
 DNSHandler DNSHandler::instance;
 

louloulibs/network/dns_handler.hpp

@@ -20,8 +20,9 @@ class DNSSocketHandler;
 
 class DNSHandler
 {
-public:
+private:
   DNSHandler();
+public:
   ~DNSHandler() = default;
   DNSHandler(const DNSHandler&) = delete;
   DNSHandler(DNSHandler&&) = delete;

louloulibs/network/tcp_socket_handler.hpp

@@ -204,8 +204,8 @@ protected:
   /**
    * Called when we detect a disconnection from the remote host.
    */
-  virtual void on_connection_close(const std::string& error) = 0;
+  virtual void on_connection_close(const std::string&) {}
-  virtual void on_connection_failed(const std::string& error) = 0;
+  virtual void on_connection_failed(const std::string&) {}
 
 private:
 #ifdef BOTAN_FOUND

src/identd/identd_socket.hpp

@@ -22,8 +22,6 @@ class IdentdSocket: public TCPSocketHandler
   std::string generate_answer(const BiboumiComponent& biboumi, uint16_t local, uint16_t remote);
 
   void parse_in_buffer(const std::size_t size) override final;
-  void on_connection_close(const std::string&) override final
-  {}
 
   bool is_connected() const override final
   {
@@ -35,10 +33,5 @@ class IdentdSocket: public TCPSocketHandler
   }
 
  private:
-  void connect() override
-  { assert(false); }
-  void on_connection_failed(const std::string&) override final
-  { assert(false); }
-
   IdentdServer& server;
 };