From a261848ef4ae8d59433efb151814faa9db6d2ab5 Mon Sep 17 00:00:00 2001 From: mathieui Date: Sun, 2 Aug 2026 19:37:44 +0200 Subject: [PATCH] build: fix wrong constextpr preventing some compilers from building biboumi The latest commit introduced an issue because a std::string cannot really be constexpr. Fortunately, a cosnt char* const works just as well here. --- src/database/sqlite3_engine.cpp | 2 +- src/database/sqlite3_engine.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/database/sqlite3_engine.cpp b/src/database/sqlite3_engine.cpp index 7b4f541..5128065 100644 --- a/src/database/sqlite3_engine.cpp +++ b/src/database/sqlite3_engine.cpp @@ -135,7 +135,7 @@ DatabaseType Sqlite3Engine::get_type() { bool Sqlite3Engine::is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode) { // https://sqlite.org/pragma.html#pragma_journal_mode - for (const std::string &s : Sqlite3Engine::valid_sqlite_journal_modes) { + for (const char* s : Sqlite3Engine::valid_sqlite_journal_modes) { if (sqlite_journal_mode == s) return true; } diff --git a/src/database/sqlite3_engine.hpp b/src/database/sqlite3_engine.hpp index 9e29bed..13ed4d0 100644 --- a/src/database/sqlite3_engine.hpp +++ b/src/database/sqlite3_engine.hpp @@ -48,7 +48,7 @@ private: // https://sqlite.org/lang_analyze.html "PRAGMA optimize=0x10002", }; - constexpr static std::string valid_sqlite_journal_modes[6] = { + constexpr static const char *const valid_sqlite_journal_modes[6] = { "DELETE", "TRUNCATE", "PERSIST", "MEMORY", "WAL", "OFF", }; static bool is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode);