mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize tcp_socket::on_send by using vector::erase() only once per call

Browse Source
This commit is contained in:
louiz’
2016-10-20 20:08:29 +02:00
parent ce06c25e93
commit aa4255224e
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
louloulibs/network/tcp_socket_handler.cpp
+7 -6
View File
@@ -305,23 +305,24 @@ void TCPSocketHandler::on_send()
else else
{ {
// remove all the strings that were successfully sent. // remove all the strings that were successfully sent.
for (auto it = this->out_buf.begin(); auto it = this->out_buf.begin();
it != this->out_buf.end();) while (it != this->out_buf.end())
{ {
if (static_cast<size_t>(res) >= (*it).size()) if (static_cast<size_t>(res) >= it->size())
{ {
res -= (*it).size(); res -= it->size();
it = this->out_buf.erase(it); ++it;
} }
else else
{ {
// If one string has partially been sent, we use substr to // If one string has partially been sent, we use substr to
// crop it // crop it
if (res > 0) if (res > 0)
(*it) = (*it).substr(res, std::string::npos); *it = it->substr(res, std::string::npos);
break; break;
} }
} }
this->out_buf.erase(this->out_buf.begin(), it);
if (this->out_buf.empty()) if (this->out_buf.empty())
this->poller->stop_watching_send_events(this); this->poller->stop_watching_send_events(this);
} }