Pass the shared_ptr by reference, to avoid useless copies

louloulibs/network/dns_handler.cpp

@@ -17,7 +17,7 @@ using namespace std::string_literals;
 
 std::unique_ptr<DNSSocketHandler> DNSHandler::socket_handler{};
 
-DNSHandler::DNSHandler(std::shared_ptr<Poller> poller)
+DNSHandler::DNSHandler(std::shared_ptr<Poller>& poller)
 {
   dns_init(nullptr, 0);
   const auto socket = dns_open(nullptr);

louloulibs/network/dns_handler.hpp

@@ -14,7 +14,7 @@ class Poller;
 class DNSHandler
 {
 public:
-  explicit DNSHandler(std::shared_ptr<Poller> poller);
+  explicit DNSHandler(std::shared_ptr<Poller>& poller);
   ~DNSHandler() = default;
 
   DNSHandler(const DNSHandler&) = delete;

louloulibs/network/dns_socket_handler.cpp

@@ -7,7 +7,7 @@
 
 #include <udns.h>
 
-DNSSocketHandler::DNSSocketHandler(std::shared_ptr<Poller> poller,
+DNSSocketHandler::DNSSocketHandler(std::shared_ptr<Poller>& poller,
                                    const socket_t socket):
   SocketHandler(poller, socket)
 {

louloulibs/network/dns_socket_handler.hpp

@@ -12,7 +12,7 @@
 class DNSSocketHandler: public SocketHandler
 {
 public:
-  explicit DNSSocketHandler(std::shared_ptr<Poller> poller, const socket_t socket);
+  explicit DNSSocketHandler(std::shared_ptr<Poller>& poller, const socket_t socket);
   ~DNSSocketHandler();
   DNSSocketHandler(const DNSSocketHandler&) = delete;
   DNSSocketHandler(DNSSocketHandler&&) = delete;

louloulibs/network/socket_handler.hpp

@@ -10,7 +10,7 @@ using socket_t = int;
 class SocketHandler
 {
 public:
-  explicit SocketHandler(std::shared_ptr<Poller> poller, const socket_t socket):
+  explicit SocketHandler(std::shared_ptr<Poller>& poller, const socket_t socket):
     poller(poller),
     socket(socket)
   {}

louloulibs/network/tcp_client_socket_handler.cpp

@@ -11,7 +11,7 @@
 
 using namespace std::string_literals;
 
-TCPClientSocketHandler::TCPClientSocketHandler(std::shared_ptr<Poller> poller):
+TCPClientSocketHandler::TCPClientSocketHandler(std::shared_ptr<Poller>& poller):
    TCPSocketHandler(poller),
    hostname_resolution_failed(false),
    connected(false),

louloulibs/network/tcp_client_socket_handler.hpp

@@ -5,7 +5,7 @@
 class TCPClientSocketHandler: public TCPSocketHandler
 {
  public:
-  TCPClientSocketHandler(std::shared_ptr<Poller> poller);
+  TCPClientSocketHandler(std::shared_ptr<Poller>& poller);
   ~TCPClientSocketHandler();
   /**
    * Connect to the remote server, and call on_connected() if this

louloulibs/network/tcp_server_socket.hpp

@@ -18,7 +18,7 @@ template <typename RemoteSocketType>
 class TcpSocketServer: public SocketHandler
 {
  public:
-  TcpSocketServer(std::shared_ptr<Poller> poller, const uint16_t port):
+  TcpSocketServer(std::shared_ptr<Poller>& poller, const uint16_t port):
       SocketHandler(poller, -1)
   {
     if ((this->socket = ::socket(AF_INET6, SOCK_STREAM, 0)) == -1)

louloulibs/network/tcp_socket_handler.cpp

@@ -44,7 +44,7 @@ using namespace std::chrono_literals;
 
 namespace ph = std::placeholders;
 
-TCPSocketHandler::TCPSocketHandler(std::shared_ptr<Poller> poller):
+TCPSocketHandler::TCPSocketHandler(std::shared_ptr<Poller>& poller):
   SocketHandler(poller, -1),
   use_tls(false)
 #ifdef BOTAN_FOUND

louloulibs/network/tcp_socket_handler.hpp

@@ -60,7 +60,7 @@ class TCPSocketHandler: public SocketHandler
 protected:
   ~TCPSocketHandler();
 public:
-  explicit TCPSocketHandler(std::shared_ptr<Poller> poller);
+  explicit TCPSocketHandler(std::shared_ptr<Poller>& poller);
   TCPSocketHandler(const TCPSocketHandler&) = delete;
   TCPSocketHandler(TCPSocketHandler&&) = delete;
   TCPSocketHandler& operator=(const TCPSocketHandler&) = delete;

louloulibs/xmpp/xmpp_component.cpp

@@ -39,7 +39,7 @@ static std::set<std::string> kickable_errors{
     "malformed-error"
     };
 
-XmppComponent::XmppComponent(std::shared_ptr<Poller> poller, const std::string& hostname, const std::string& secret):
+XmppComponent::XmppComponent(std::shared_ptr<Poller>& poller, const std::string& hostname, const std::string& secret):
   TCPClientSocketHandler(poller),
   ever_auth(false),
   first_connection_try(true),

louloulibs/xmpp/xmpp_component.hpp

@@ -43,7 +43,7 @@
 class XmppComponent: public TCPClientSocketHandler
 {
 public:
-  explicit XmppComponent(std::shared_ptr<Poller> poller, const std::string& hostname, const std::string& secret);
+  explicit XmppComponent(std::shared_ptr<Poller>& poller, const std::string& hostname, const std::string& secret);
   virtual ~XmppComponent() = default;
 
   XmppComponent(const XmppComponent&) = delete;