mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: fix wrong constextpr preventing some compilers from building biboumi

Browse Source 
The latest commit introduced an issue because a std::string cannot
really be constexpr. Fortunately, a cosnt char* const works just as well
here.
This commit is contained in:
mathieui
2026-08-02 19:37:44 +02:00
parent ad14748a30
commit a261848ef4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/database/sqlite3_engine.cpp
+1 -1
View File
@@ -135,7 +135,7 @@ DatabaseType Sqlite3Engine::get_type() {
bool Sqlite3Engine::is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode) { bool Sqlite3Engine::is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode) {
// https://sqlite.org/pragma.html#pragma_journal_mode // https://sqlite.org/pragma.html#pragma_journal_mode
for (const std::string &s : Sqlite3Engine::valid_sqlite_journal_modes) { for (const char* s : Sqlite3Engine::valid_sqlite_journal_modes) {
if (sqlite_journal_mode == s) if (sqlite_journal_mode == s)
return true; return true;
} }
src/database/sqlite3_engine.hpp
+1 -1
View File
@@ -48,7 +48,7 @@ private:
// https://sqlite.org/lang_analyze.html // https://sqlite.org/lang_analyze.html
"PRAGMA optimize=0x10002", "PRAGMA optimize=0x10002",
}; };
constexpr static std::string valid_sqlite_journal_modes[6] = { constexpr static const char *const valid_sqlite_journal_modes[6] = {
"DELETE", "TRUNCATE", "PERSIST", "MEMORY", "WAL", "OFF", "DELETE", "TRUNCATE", "PERSIST", "MEMORY", "WAL", "OFF",
}; };
static bool is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode); static bool is_valid_sqlite_journal_mode(std::string &sqlite_journal_mode);