mike/biboumi
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix parse_datetime by always using a 'z' as the timezone

Browse Source 
Because some plateform accept Z and z, but some only accept z…
This commit is contained in:
louiz’
2016-10-03 17:58:16 +02:00
parent fca25b7704
commit e5b392ece8
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
louloulibs/utils/time.cpp
+2 -1
View File
@@ -14,8 +14,9 @@ std::string to_string(const std::time_t& timestamp)
std::time_t parse_datetime(const std::string& stamp)
{
auto stamp2 = stamp.substr(0, stamp.size() - 1) + "z";
struct tm tm;
if (!::strptime(stamp.data(), "%FT%T%Z", &tm))
if (!::strptime(stamp2.data(), "%FT%T%Z", &tm))
return -1;
auto res = ::timegm(&tm);
return res;
tests/utils.cpp
+2 -5
View File
@@ -124,10 +124,7 @@ TEST_CASE("time_to_string")
TEST_CASE("parse_datetime")
{
const auto time = utils::parse_datetime("1970-01-01T00:00:00Z");
CHECK(time == 0);
CHECK(utils::parse_datetime("2016-08-29T14:29:28Z") == 1472480968);
CHECK(utils::parse_datetime("2016-08-29T14:29:28UT") == 1472480968);
CHECK(utils::parse_datetime("2016-08-29T14:29:28GMT") == 1472480968);
CHECK(utils::parse_datetime("1970-01-01T00:00:00z") == 0);
CHECK(utils::parse_datetime("2016-08-29T14:29:29Z") == 1472480969);
CHECK(utils::parse_datetime("blah") == -1);
}